I created a filter for doing Save automatically (https://github.com/RemiBou/Toss.Blazor/blob/master/Toss.Server/Data/RavenDBSaveAsyncActionFilter.cs) is that a bad practice for you ?

Related: you may be interested in RavenDB.DependencyInjection.

It lets you do what Ayende says here in the post, only with less code. Here's how it looks:

// in appsettings
"RavenSettings": {
    "Urls": [
       "http://live-test.ravendb.net"
    ],
    "DatabaseName": "Demo",
    "CertFilePath": "",
    "CertPassword": ""
}

// In Startup.cs
services.AddRavenDbDocStore();
services.AddRavenDbAsyncSession(); 

And you're done. There's also some optional extensions that let you custom load a certificate (e.g. from the cert store), as well as some overloads for configuring the doc store before initialization. It's available on NuGet as RavenDB.DependencyInjection.

@Remi, that's good: an action filter for Razor/Blazor pages to call .SaveChangesAsync(). In fact, I do exactly that in RavenDB.Identity Razor sample project. For MVC/API projects, I recommend a RavenController base class.

Oren - you might want to take a look at the constructor in the UserController class.

The patterns you posted are great and match the recommended approach from Microsoft. What I don't like is the template code in the controller.

private readonly IAsyncDocumentSession _session;

public UsersController(IAsyncDocumentSession session)
{
    _session = session;
}

When every controller uses session this code has to basically be copy-pasted in each one. Which I don't like that much.

Instead I made a BaseController

public class BaseController : ControllerBase {
    protected IDocumentSession RavenSession => HttpContext.Items["RavenDBSession"] as IDocumentSession;
}

And RavenDBMiddleware

public class RavenDBMiddlewere {
        private readonly RequestDelegate _next;
        private IDocumentStore _documentStore;

        public RavenDBMiddlewere( RequestDelegate next, IDocumentStore documentStore ) {
            _next = next;
            _documentStore = documentStore;
        }

        public async Task Invoke( HttpContext context ) {
        context.Items["RavenDBSession"] = _documentStore.OpenSession();

        await _next.Invoke( context );
        
        var session = (IDocumentSession) context.Items["RavenDBSession"];
        
        session.SaveChanges();
    }
}

public static class RavenDBMiddlewereExtensions {
    public static IApplicationBuilder UseRavenDB( this IApplicationBuilder builder ) {
        return builder.UseMiddleware<RavenDBMiddlewere>();
    }
}

Which I invoke before app.UseMvc() in the Startup.cs Configure method.

This approach is quite similar to the old recommended approach with ASP.NET MVC and .NET 4.7